Minecraft Sample docs #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dgkanatsios
reviewed
Sep 28, 2022
samples/minecraft/README.md
Outdated
|
|
||
| Check the [quickstart](https://github.com/PlayFab/thundernetes/blob/main/docs/quickstart.md) on how to run the Minecraft sample on thundernetes. | ||
|
|
||
| This image is based on the itzg/minecraft-server docker image, but modified to initiate the server with the GSDK wrapper, since Minecraft is not an OSS. The modified dockerfile can be found [here](https://github.com/rnjohn/docker-minecraft-server-gsdk). |
There was a problem hiding this comment.
Yup, I added more info in the README, let me know if it's alright
dgkanatsios
reviewed
Sep 28, 2022
samples/minecraft/sample.yaml
Outdated
| template: | ||
| spec: | ||
| containers: | ||
| - image: rnjohn/minecraft-server-test |
There was a problem hiding this comment.
image should be tagged. Is this on Docker Hub? It would be better if the registry is explicit
There was a problem hiding this comment.
Yes, the image is on Docker Hub, I added the latest tag
dgkanatsios
reviewed
Sep 28, 2022
docs/quickstart/sample-minecraft.md
Outdated
| title: Minecraft sample | ||
| parent: Samples | ||
| grand_parent: Quickstart | ||
| nav_order: 2 |
There was a problem hiding this comment.
let's have this as "3" so it's listed below .NET Core sample and OpenArena
dgkanatsios
reviewed
Sep 28, 2022
samples/minecraft/README.md
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Minecraft GSDK sample for thundernetes | |||
|
|
|||
| Check the [quickstart](https://github.com/PlayFab/thundernetes/blob/main/docs/quickstart.md) on how to run the Minecraft sample on thundernetes. | |||
There was a problem hiding this comment.
nit: please have Thundernetes with a capital "T"
dgkanatsios
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a documentation to start a Minecraft Java Edition server using Thundernetes. A sample.yaml file was created to be applied to the kubernetes cluster and also there is instructions on how to do so.